Talking Drupal #166 - Code Reviews Like a Human

Talking Drupal · Apr 9, 2018 · 1h 8m

In episode #166 we review 8 tips for conducting code reviews like a human with Michael Lynch. www.talkingdrupal.com/166

Topics

March 28th Security Release

Overview of Code Review Like a Human

Michel Lynch

8 Tips

Settle style arguments with a style guide

Let computers do the boring parts

Be generous with code examples

Never say "you"

Frame feedback as requests, not commands

Offer sincere praise

Aim to bring the code up a letter grade or two

Handle stalemates proactively

Resources

Drupal core - Highly critical - Remote Code Execution - SA-CORE-2018-002

Can We Code Without Comments?

How to Do…